Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10cc8844 authored by Govindarajulu Varadarajan's avatar Govindarajulu Varadarajan Committed by David S. Miller
Browse files

enic: fix return value in _vnic_dev_cmd 



Hardware (in readq(&devcmd->args[0])) returns positive number in case of error.
But _vnic_dev_cmd should return a negative value in case of error.

Signed-off-by: default avatarGovindarajulu Varadarajan <_govind@gmx.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e0f31d84

drivers/net/ethernet/cisco/enic/vnic_dev.c

+2 −2
Original line number Diff line number Diff line
@@ -312,12 +312,12 @@ static int _vnic_dev_cmd(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, 
				err = (int)readq(&devcmd->args[0]);

				if (err == ERR_EINVAL &&

				    cmd == CMD_CAPABILITY)

					return err;

					return -err;

				if (err != ERR_ECMDUNKNOWN ||

				    cmd != CMD_CAPABILITY)

					pr_err("Error %d devcmd %d\n",

						err, _CMD_N(cmd));

				return err;

				return -err;

			}



			if (_CMD_DIR(cmd) & _CMD_DIR_READ) {