Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1096e871 authored by Stephen Hemminger's avatar Stephen Hemminger Committed by Jeff Garzik
Browse files

[PATCH] skge: handle VLAN checksum correctly on yukon rev 0 



If using UDP over VLAN, with the skge driver there is a possibility
of generating an incorrect checksum. This is a unlikely occurrence
because it is only an issue on Yukon revision 0, and that revision
doesn't seem to exist on any current hardware (probably early prototype).

Signed-off-by: default avatarStephen Hemminger <shemminger@osdl.org>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent c08ad1e3

drivers/net/skge.c

+1 −3
Original line number Diff line number Diff line
@@ -2300,14 +2300,12 @@ static int skge_xmit_frame(struct sk_buff *skb, struct net_device *dev) 
	td->dma_hi = map >> 32;



	if (skb->ip_summed == CHECKSUM_HW) {

		const struct iphdr *ip

			= (const struct iphdr *) (skb->data + ETH_HLEN);

		int offset = skb->h.raw - skb->data;



		/* This seems backwards, but it is what the sk98lin

		 * does.  Looks like hardware is wrong?

		 */

		if (ip->protocol == IPPROTO_UDP

		if (skb->h.ipih->protocol == IPPROTO_UDP

	            && hw->chip_rev == 0 && hw->chip_id == CHIP_ID_YUKON)

			control = BMU_TCP_CHECK;

		else