Commit 107b7d6a authored Mar 19, 2018 by Miquel Raynal Committed by Boris Brezillon Mar 20, 2018

mtd: rawnand: avoid setting again the timings to mode 0 after a reset

After a nand_reset_data_interface(), both the NAND chip and the NAND
controller use timing mode 0. The previously defined data interface for
this chip has been saved and is supposed to be restored after that.
However, if the saved data interface also refers to timing mode 0, there
is no need to re-apply them again.

Also, as nand_setup_data_interface() uses ->set/get_features(), it could
lead to issues when doing the reset at probe time as the parameter page
is not available yet to know if these functions are supported or not.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

parent 415ae78f

drivers/mtd/nand/raw/nand_base.c

+10 −0

Original line number	Original line	Diff line number	Diff line
	@@ -2816,6 +2816,16 @@ int nand_reset(struct nand_chip *chip, int chipnr)
	if (ret)		if (ret)
	return ret;		return ret;

			/*
			* A nand_reset_data_interface() put both the NAND chip and the NAND
			* controller in timings mode 0. If the default mode for this chip is
			* also 0, no need to proceed to the change again. Plus, at probe time,
			* nand_setup_data_interface() uses ->set/get_features() which would
			* fail anyway as the parameter page is not available yet.
			*/
			if (!chip->onfi_timing_mode_default)
			return 0;

	chip->data_interface = saved_data_intf;		chip->data_interface = saved_data_intf;
	ret = nand_setup_data_interface(chip, chipnr);		ret = nand_setup_data_interface(chip, chipnr);
	if (ret)		if (ret)