Commit 104b2d87 authored Jul 03, 2016 by Sudip Mukherjee Committed by Alexandre Belloni Jul 19, 2016

rtc: m41t80: use devm_add_action_or_reset()

If devm_add_action() fails we are explicitly calling the cleanup to free
the resources allocated. Lets use the helper devm_add_action_or_reset()
and return directly in case of error, as we know that the cleanup function
has been already called by the helper if there was any error.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

parent 6785b3b6

drivers/rtc/rtc-m41t80.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -829,10 +829,9 @@ static int m41t80_probe(struct i2c_client *client,
		return rc;
		}

		rc = devm_add_action(&client->dev, m41t80_remove_sysfs_group,
		rc = devm_add_action_or_reset(&client->dev, m41t80_remove_sysfs_group,
		&client->dev);
		if (rc) {
		m41t80_remove_sysfs_group(&client->dev);
		dev_err(&client->dev,
		"Failed to add sysfs cleanup action: %d\n", rc);
		return rc;