Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1016d567 authored by Orson Zhai's avatar Orson Zhai Committed by Jonathan Cameron
Browse files

iio: core: Fix suspicious sizeof usage 



Pointer size is variours in different system, say 32bit for 4 and 64bit
for 8. The 'sizeof(infomask)' may lead to wrong bit numbers.

Signed-off-by: default avatarOrson Zhai <orson.zhai@spreadtrum.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 80a49fd8

drivers/iio/industrialio-core.c

+2 −2
Original line number Diff line number Diff line
@@ -1089,7 +1089,7 @@ static int iio_device_add_info_mask_type(struct iio_dev *indio_dev, 
{

	int i, ret, attrcount = 0;



	for_each_set_bit(i, infomask, sizeof(infomask)*8) {

	for_each_set_bit(i, infomask, sizeof(*infomask)*8) {

		if (i >= ARRAY_SIZE(iio_chan_info_postfix))

			return -EINVAL;

		ret = __iio_add_chan_devattr(iio_chan_info_postfix[i],
@@ -1118,7 +1118,7 @@ static int iio_device_add_info_mask_type_avail(struct iio_dev *indio_dev, 
	int i, ret, attrcount = 0;

	char *avail_postfix;



	for_each_set_bit(i, infomask, sizeof(infomask) * 8) {

	for_each_set_bit(i, infomask, sizeof(*infomask) * 8) {

		avail_postfix = kasprintf(GFP_KERNEL,

					  "%s_available",

					  iio_chan_info_postfix[i]);