Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ffdaf5b authored by Sowmini Varadhan's avatar Sowmini Varadhan Committed by David S. Miller
Browse files

net/sock: add WARN_ON(parent->sk) in sock_graft() 



sock_graft() unilaterally sets up parent->sk based on the
assumption that the existing parent->sk is null. If this
condition is not true, then the existing parent->sk would
be leaked, so add a WARN_ON() to alert callers who may fall
in this category.

Signed-off-by: default avatarSowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0933a578

include/net/sock.h

+1 −0
Original line number Diff line number Diff line
@@ -1697,6 +1697,7 @@ static inline void sock_orphan(struct sock *sk) 


static inline void sock_graft(struct sock *sk, struct socket *parent)

{

	WARN_ON(parent->sk);

	write_lock_bh(&sk->sk_callback_lock);

	sk->sk_wq = parent->wq;

	parent->sk = sk;