Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f4e918c authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: wm_adsp: Limit firmware control name to ALSA control name size 



ALSA only supports control names up to 44 bytes, so there is no point
allocating a whole page of memory to hold the control name, just limit
the control name to 44 bytes.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6958eb2a

sound/soc/codecs/wm_adsp.c

+2 −2
Original line number Diff line number Diff line
@@ -789,7 +789,7 @@ static int wm_adsp_create_control(struct wm_adsp *dsp, 
	char *region_name;

	int ret;



	name = kmalloc(PAGE_SIZE, GFP_KERNEL);

	name = kmalloc(SNDRV_CTL_ELEM_ID_NAME_MAXLEN, GFP_KERNEL);

	if (!name)

		return -ENOMEM;
@@ -814,7 +814,7 @@ static int wm_adsp_create_control(struct wm_adsp *dsp, 
		goto err_name;

	}



	snprintf(name, PAGE_SIZE, "DSP%d %s %x",

	snprintf(name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, "DSP%d %s %x",

		 dsp->num, region_name, alg_region->alg);



	list_for_each_entry(ctl, &dsp->ctl_list,