Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f4821e7 authored May 03, 2005 by David S. Miller Committed by David S. Miller May 03, 2005

[XFRM/RTNETLINK]: Decrement qlen properly in {xfrm_,rt}netlink_rcv().



If we free up a partially processed packet because it's
skb->len dropped to zero, we need to decrement qlen because
we are dropping out of the top-level loop so it will do
the decrement for us.

Spotted by Herbert Xu.

Signed-off-by: David S. Miller <davem@davemloft.net>

parent 09e14305

net/core/rtnetlink.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -632,8 +632,10 @@ static void rtnetlink_rcv(struct sock *sk, int len)
		if (skb->len)
		skb_queue_head(&sk->sk_receive_queue,
		skb);
		else
		else {
		kfree_skb(skb);
		qlen--;
		}
		break;
		}
		kfree_skb(skb);

net/xfrm/xfrm_user.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1024,8 +1024,10 @@ static void xfrm_netlink_rcv(struct sock *sk, int len)
		if (skb->len)
		skb_queue_head(&sk->sk_receive_queue,
		skb);
		else
		else {
		kfree_skb(skb);
		qlen--;
		}
		break;
		}
		kfree_skb(skb);