Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0eed9cf5 authored by Mintz, Yuval's avatar Mintz, Yuval Committed by David S. Miller
Browse files

net: Zero ifla_vf_info in rtnl_fill_vfinfo() 



Some of the structure's fields are not initialized by the
rtnetlink. If driver doesn't set those in ndo_get_vf_config(),
they'd leak memory to user.

Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@cavium.com>
CC: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: default avatarGreg Rose <gvrose8192@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dd0da17b

net/core/rtnetlink.c

+2 −1
Original line number Diff line number Diff line
@@ -1124,6 +1124,8 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, 
	struct ifla_vf_mac vf_mac;

	struct ifla_vf_info ivi;



	memset(&ivi, 0, sizeof(ivi));



	/* Not all SR-IOV capable drivers support the

	 * spoofcheck and "RSS query enable" query.  Preset to

	 * -1 so the user space tool can detect that the driver
@@ -1132,7 +1134,6 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb, 
	ivi.spoofchk = -1;

	ivi.rss_query_en = -1;

	ivi.trusted = -1;

	memset(ivi.mac, 0, sizeof(ivi.mac));

	/* The default value for VF link state is "auto"

	 * IFLA_VF_LINK_STATE_AUTO which equals zero

	 */