Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ede5804 authored by Dan Carpenter's avatar Dan Carpenter Committed by Tomi Valkeinen
Browse files

tgafb: potential NULL dereference in init 



Static checkers complain that there are paths where "tga_type_name" can
be NULL.  I've re-arranged the code slightly so that's impossible.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 6fc19c40

drivers/video/tgafb.c

+2 −3
Original line number Diff line number Diff line
@@ -1490,10 +1490,9 @@ tgafb_init_fix(struct fb_info *info) 
		if (tga_bus_tc)

			tga_type_name = "Digital ZLX-E3";

		break;

	default:

		tga_type_name = "Unknown";

		break;

	}

	if (!tga_type_name)

		tga_type_name = "Unknown";



	strlcpy(info->fix.id, tga_type_name, sizeof(info->fix.id));