Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e772b33 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Christoph Hellwig
Browse files

bfa: remove useless return variables 



This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
    when strict
return
- ret
+ C
;
// </smpl>

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Acked-by: default avatarSudarsana Kalluru <Sudarsana.Kalluru@qlogic.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 03a6c3ff

drivers/scsi/bfa/bfad_bsg.c

+4 −6
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ int 
bfad_iocmd_ioc_enable(struct bfad_s *bfad, void *cmd)

{

	struct bfa_bsg_gen_s *iocmd = (struct bfa_bsg_gen_s *)cmd;

	int	rc = 0;

	unsigned long	flags;



	spin_lock_irqsave(&bfad->bfad_lock, flags);
@@ -34,7 +33,7 @@ bfad_iocmd_ioc_enable(struct bfad_s *bfad, void *cmd) 
	if (!bfa_ioc_is_disabled(&bfad->bfa.ioc)) {

		spin_unlock_irqrestore(&bfad->bfad_lock, flags);

		iocmd->status = BFA_STATUS_OK;

		return rc;

		return 0;

	}



	init_completion(&bfad->enable_comp);
@@ -43,21 +42,20 @@ bfad_iocmd_ioc_enable(struct bfad_s *bfad, void *cmd) 
	spin_unlock_irqrestore(&bfad->bfad_lock, flags);

	wait_for_completion(&bfad->enable_comp);



	return rc;

	return 0;

}



int

bfad_iocmd_ioc_disable(struct bfad_s *bfad, void *cmd)

{

	struct bfa_bsg_gen_s *iocmd = (struct bfa_bsg_gen_s *)cmd;

	int	rc = 0;

	unsigned long	flags;



	spin_lock_irqsave(&bfad->bfad_lock, flags);

	if (bfa_ioc_is_disabled(&bfad->bfa.ioc)) {

		spin_unlock_irqrestore(&bfad->bfad_lock, flags);

		iocmd->status = BFA_STATUS_OK;

		return rc;

		return 0;

	}



	if (bfad->disable_active) {
@@ -74,7 +72,7 @@ bfad_iocmd_ioc_disable(struct bfad_s *bfad, void *cmd) 
	bfad->disable_active = BFA_FALSE;

	iocmd->status = BFA_STATUS_OK;



	return rc;

	return 0;

}



static int