Commit 0e214ad8 authored Dec 17, 2010 by Dan Carpenter Committed by David S. Miller Dec 23, 2010

USB: mcs7830: return negative if auto negotiate fails



The original code returns 0 on success and 1 on failure.  In fact, at
this point, "ret" is already either zero or a negative error code so
we can just return it directly.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fdac1e06

drivers/net/usb/mcs7830.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -355,7 +355,7 @@ static int mcs7830_set_autoneg(struct usbnet *dev, int ptrUserPhyMode)
	if (!ret)		if (!ret)
	ret = mcs7830_write_phy(dev, MII_BMCR,		ret = mcs7830_write_phy(dev, MII_BMCR,
	BMCR_ANENABLE \| BMCR_ANRESTART );		BMCR_ANENABLE \| BMCR_ANRESTART );
	return ret < 0 ? : 0;		return ret;
	}		}