Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e083662 authored by Christian Lütke-Stetzkamp's avatar Christian Lütke-Stetzkamp Committed by Greg Kroah-Hartman
Browse files

staging: mt7621-mmc: Fix: copy_from_user() returns a positive value 



copy_from_user() returns a positive value in case of an error, to fix
this the check is turned around, also a better return value is chosen.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Suggested-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarChristian Lütke-Stetzkamp <christian@lkamp.de>
Reviewed-by: default avatarNeilBrown <neil@brown.name>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2436c315

drivers/staging/mt7621-mmc/dbg.c

+2 −3
Original line number Diff line number Diff line
@@ -265,9 +265,8 @@ static ssize_t msdc_debug_proc_write(struct file *file, 
	if (count > 255)

		count = 255;



	ret = copy_from_user(cmd_buf, buf, count);

	if (ret < 0)

		return -1;

	if (copy_from_user(cmd_buf, buf, count))

		return -EFAULT;



	cmd_buf[count] = '\0';

	printk("msdc Write %s\n", cmd_buf);