Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0db75790 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix invalid snd_BUG_ON() in alc271_hp_gate_mic_jack() 



The fixup function is called multiple times before parsing the pins,
so snd_BUG_ON() hits when loaded.  Move it to the proper place in the
if block.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 2cf215bf

sound/pci/hda/patch_realtek.c

+5 −4
Original line number Diff line number Diff line
@@ -2729,13 +2729,14 @@ static void alc271_hp_gate_mic_jack(struct hda_codec *codec, 
{

	struct alc_spec *spec = codec->spec;



	if (action == HDA_FIXUP_ACT_PROBE) {

		if (snd_BUG_ON(!spec->gen.am_entry[1].pin ||

			       !spec->gen.autocfg.hp_pins[0]))

			return;

	if (action == HDA_FIXUP_ACT_PROBE)

		snd_hda_jack_set_gating_jack(codec, spec->gen.am_entry[1].pin,

					     spec->gen.autocfg.hp_pins[0]);

	}

}



enum {

	ALC269_FIXUP_SONY_VAIO,