Commit 0d0ab120 authored Aug 15, 2013 by Dan Carpenter Committed by Ben Myers Aug 26, 2013

xfs: check for underflow in xfs_iformat_fork()



The "di_size" variable comes from the disk and it's a signed 64 bit.
We check the upper limit but we should check for negative numbers as
well.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>

parent 98f7462c

fs/xfs/xfs_inode_fork.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -167,7 +167,8 @@ xfs_iformat_fork(
		}

		di_size = be64_to_cpu(dip->di_size);
		if (unlikely(di_size > XFS_DFORK_DSIZE(dip, ip->i_mount))) {
		if (unlikely(di_size < 0 \|\|
		di_size > XFS_DFORK_DSIZE(dip, ip->i_mount))) {
		xfs_warn(ip->i_mount,
		"corrupt inode %Lu (bad size %Ld for local inode).",
		(unsigned long long) ip->i_ino,