Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0cfdec7a authored by Jesper Juhl's avatar Jesper Juhl Committed by Herbert Xu
Browse files

crypto: In crypto_add_alg(), 'exact' wants to be initialized to 0 



We declare 'exact' without initializing it and then do:

[...]
	if (strlen(p->cru_driver_name))
		exact = 1;

	if (priority && !exact)
		return -EINVAL;

[...]

If the first 'if' is not true, then the second will test an
uninitialized 'exact'.
As far as I can tell, what we want is for 'exact' to be initialized to
0 (zero/false).

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Acked-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 65a4a573

crypto/crypto_user.c

+1 −1
Original line number Diff line number Diff line
@@ -304,7 +304,7 @@ static int crypto_del_alg(struct sk_buff *skb, struct nlmsghdr *nlh, 
static int crypto_add_alg(struct sk_buff *skb, struct nlmsghdr *nlh,

			  struct nlattr **attrs)

{

	int exact;

	int exact = 0;

	const char *name;

	struct crypto_alg *alg;

	struct crypto_user_alg *p = nlmsg_data(nlh);