Commit 0ce15000 authored Jan 22, 2023 by Greg Kroah-Hartman

Revert "ext4: fix delayed allocation bug in ext4_clu_mapped for bigalloc + inline"

This reverts commit 1ed1eef0 which is
commit 131294c35ed6f777bd4e79d42af13b5c41bf2775 upstream.

Eric writes:
	I recommend not backporting this patch or the other three
	patches apparently intended to support it to 4.19 stable.  All
	these patches are related to ext4's bigalloc feature, which was
	experimental as of 4.19 (expressly noted by contemporary
	versions of e2fsprogs) and also suffered from a number of bugs.
	A significant number of additional patches that were applied to
	5.X kernels over time would have to be backported to 4.19 for
	the patch below to function correctly. It's really not worth
	doing that given bigalloc's experimental status as of 4.19 and
	the very rare combination of the bigalloc and inline features.

Link: https://lore.kernel.org/r/Y8mAe1SlcLD5fykg@debian-BULLSEYE-live-builder-AMD64


Cc: Eric Whitney <enwlinux@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 32313c11

fs/ext4/extents.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -5984,14 +5984,6 @@ int ext4_clu_mapped(struct inode *inode, ext4_lblk_t lclu)
		struct ext4_extent *extent;
		ext4_lblk_t first_lblk, first_lclu, last_lclu;

		/*
		* if data can be stored inline, the logical cluster isn't
		* mapped - no physical clusters have been allocated, and the
		* file has no extents
		*/
		if (ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA))
		return 0;

		/* search for the extent closest to the first block in the cluster */
		path = ext4_find_extent(inode, EXT4_C2B(sbi, lclu), NULL, 0);
		if (IS_ERR(path)) {