Commit 0cccca06 authored May 15, 2006 by Serge E. Hallyn Committed by Linus Torvalds May 15, 2006

[PATCH] selinux: check for failed kmalloc in security_sid_to_context()



Check for NULL kmalloc return value before writing to it.

Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Acked-by: James Morris <jmorris@namei.org>
Cc: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 9be2f7c3

security/selinux/ss/services.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -594,6 +594,10 @@ int security_sid_to_context(u32 sid, char *scontext, u32 scontext_len)

		*scontext_len = strlen(initial_sid_to_string[sid]) + 1;
		scontextp = kmalloc(*scontext_len,GFP_ATOMIC);
		if (!scontextp) {
		rc = -ENOMEM;
		goto out;
		}
		strcpy(scontextp, initial_sid_to_string[sid]);
		*scontext = scontextp;
		goto out;