Commit 0cbf0711 authored May 19, 2008 by Tejun Heo Committed by Jeff Garzik May 19, 2008

libata: fix sata_link_hardreset() @online out parameter handling



The @online out parameter is supposed to set to true iff link is
online and reset succeeded as advertised in the function description
and callers are coded expecting that.  However, sata_link_reset()
didn't behave this way on device readiness test failure.  Fix it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent 7715a6f9

drivers/ata/libata-core.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -3653,9 +3653,13 @@ int sata_link_hardreset(struct ata_link link, const unsigned long timing,
		if (check_ready)
		rc = ata_wait_ready(link, deadline, check_ready);
		out:
		if (rc && rc != -EAGAIN)
		if (rc && rc != -EAGAIN) {
		/* online is set iff link is online && reset succeeded */
		if (online)
		*online = false;
		ata_link_printk(link, KERN_ERR,
		"COMRESET failed (errno=%d)\n", rc);
		}
		DPRINTK("EXIT, rc=%d\n", rc);
		return rc;
		}