Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c8b794c authored by Arvind Yadav's avatar Arvind Yadav Committed by Mark Brown
Browse files

ASoC: davinci-mcasp: Handle return value of devm_kasprintf 



devm_kasprintf() can fail here and we must check its return value.

Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent befff4fb

sound/soc/davinci/davinci-mcasp.c

+12 −0
Original line number Diff line number Diff line
@@ -1868,6 +1868,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) 
	if (irq >= 0) {

		irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_common",

					  dev_name(&pdev->dev));

		if (!irq_name) {

			ret = -ENOMEM;

			goto err;

		}

		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,

						davinci_mcasp_common_irq_handler,

						IRQF_ONESHOT | IRQF_SHARED,
@@ -1885,6 +1889,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) 
	if (irq >= 0) {

		irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_rx",

					  dev_name(&pdev->dev));

		if (!irq_name) {

			ret = -ENOMEM;

			goto err;

		}

		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,

						davinci_mcasp_rx_irq_handler,

						IRQF_ONESHOT, irq_name, mcasp);
@@ -1900,6 +1908,10 @@ static int davinci_mcasp_probe(struct platform_device *pdev) 
	if (irq >= 0) {

		irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_tx",

					  dev_name(&pdev->dev));

		if (!irq_name) {

			ret = -ENOMEM;

			goto err;

		}

		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,

						davinci_mcasp_tx_irq_handler,

						IRQF_ONESHOT, irq_name, mcasp);