Commit 0bc58e93 authored Sep 24, 2015 by Dan Carpenter Committed by Sebastian Reichel Sep 24, 2015

power: qcom_smbb: test the correct variable



"state" is a bool so it's never less than zero.  The intent was to test
"ret" instead.

Fixes: 56d7df87 ('power: Add Qualcomm SMBB driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>

parent 28153a31

drivers/power/qcom_smbb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -351,7 +351,7 @@ static void smbb_set_line_flag(struct smbb_charger *chg, int irq, int flag)
		int ret;

		ret = irq_get_irqchip_state(irq, IRQCHIP_STATE_LINE_LEVEL, &state);
		if (state < 0) {
		if (ret < 0) {
		dev_err(chg->dev, "failed to read irq line\n");
		return;
		}