Commit 0b4652dc authored Nov 19, 2019 by Colin Ian King Committed by Greg Kroah-Hartman Apr 21, 2020

ASoC: Intel: mrfld: fix incorrect check on p->sink



commit f5e056e1e46fcbb5f74ce560792aeb7d57ce79e6 upstream.

The check on p->sink looks bogus, I believe it should be p->source
since the following code blocks are related to p->source. Fix
this by replacing p->sink with p->source.

Fixes: 24c8d141 ("ASoC: Intel: mrfld: add DSP core controls")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Copy-paste error")
Link: https://lore.kernel.org/r/20191119113640.166940-1-colin.king@canonical.com


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2c2277de

sound/soc/intel/atom/sst-atom-controls.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1341,7 +1341,7 @@ int sst_send_pipe_gains(struct snd_soc_dai *dai, int stream, int mute)
		dai->capture_widget->name);
		w = dai->capture_widget;
		snd_soc_dapm_widget_for_each_source_path(w, p) {
		if (p->connected && !p->connected(w, p->sink))
		if (p->connected && !p->connected(w, p->source))
		continue;

		if (p->connect && p->source->power &&