Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ae99ecb authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Felipe Balbi
Browse files

usb: dwc3: omap: fix error return code in dwc3_omap_probe() 

platform_get_irq() returns an error code, but the dwc3-omap driver
ignores it and always returns -EINVAL. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af



Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 8bcd9889

drivers/usb/dwc3/dwc3-omap.c

+2 −2
Original line number Diff line number Diff line
@@ -478,8 +478,8 @@ static int dwc3_omap_probe(struct platform_device *pdev) 


	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(dev, "missing IRQ resource\n");

		return -EINVAL;

		dev_err(dev, "missing IRQ resource: %d\n", irq);

		return irq;

	}



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);