Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0aa8ff9b authored Jan 31, 2017 by Dmitry Torokhov Committed by Michael Ellerman Dec 04, 2017

powerpc: Use of for_each_node_by_name() instead of open-coding it



Instead of manually coding the loop with of_find_node_by_name(), let's
switch to the standard macro for iterating over nodes with given name.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
[mpe: Fix build failures due to typo in mpc832x_mds.c]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent df262002

arch/powerpc/platforms/83xx/mpc832x_mds.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -75,7 +75,7 @@ static void __init mpc832x_sys_setup_arch(void)
		par_io_init(np);
		of_node_put(np);

		for (np = NULL; (np = of_find_node_by_name(np, "ucc")) != NULL;)
		for_each_node_by_name(np, "ucc")
		par_io_of_config(np);
		}

arch/powerpc/platforms/83xx/mpc832x_rdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -204,7 +204,7 @@ static void __init mpc832x_rdb_setup_arch(void)
		par_io_init(np);
		of_node_put(np);

		for (np = NULL; (np = of_find_node_by_name(np, "ucc")) != NULL;)
		for_each_node_by_name(np, "ucc")
		par_io_of_config(np);
		}
		#endif /* CONFIG_QUICC_ENGINE */

arch/powerpc/platforms/83xx/mpc836x_mds.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -83,7 +83,7 @@ static void __init mpc836x_mds_setup_arch(void)
		par_io_init(np);
		of_node_put(np);

		for (np = NULL; (np = of_find_node_by_name(np, "ucc")) != NULL;)
		for_each_node_by_name(np, "ucc")
		par_io_of_config(np);
		#ifdef CONFIG_QE_USB
		/* Must fixup Par IO before QE GPIO chips are registered. */

arch/powerpc/platforms/cell/interrupt.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -315,8 +315,7 @@ static int __init setup_iic(void)
		struct cbe_iic_regs __iomem *node_iic;
		const u32 *np;

		for (dn = NULL;
		(dn = of_find_node_by_name(dn,"interrupt-controller")) != NULL;) {
		for_each_node_by_name(dn, "interrupt-controller") {
		if (!of_device_is_compatible(dn,
		"IBM,CBEA-Internal-Interrupt-Controller"))
		continue;

arch/powerpc/platforms/cell/setup.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -192,8 +192,7 @@ static void __init mpic_init_IRQ(void)
		struct device_node *dn;
		struct mpic *mpic;

		for (dn = NULL;
		(dn = of_find_node_by_name(dn, "interrupt-controller"));) {
		for_each_node_by_name(dn, "interrupt-controller") {
		if (!of_device_is_compatible(dn, "CBEA,platform-open-pic"))
		continue;