Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a9ab9bd authored by Anderson Lizardo's avatar Anderson Lizardo Committed by Gustavo Padovan
Browse files

Bluetooth: Fix incorrect strncpy() in hidp_setup_hid() 



The length parameter should be sizeof(req->name) - 1 because there is no
guarantee that string provided by userspace will contain the trailing
'\0'.

Can be easily reproduced by manually setting req->name to 128 non-zero
bytes prior to ioctl(HIDPCONNADD) and checking the device name setup on
input subsystem:

$ cat /sys/devices/pnp0/00\:04/tty/ttyS0/hci0/hci0\:1/input8/name
AAAAAA[...]AAAAAAAAf0:af:f0:af:f0:af

("f0:af:f0:af:f0:af" is the device bluetooth address, taken from "phys"
field in struct hid_device due to overflow.)

Cc: stable@vger.kernel.org
Signed-off-by: default avatarAnderson Lizardo <anderson.lizardo@openbossa.org>
Acked-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
parent 2582d529

net/bluetooth/hidp/core.c

+1 −1
Original line number Diff line number Diff line
@@ -931,7 +931,7 @@ static int hidp_setup_hid(struct hidp_session *session, 
	hid->version = req->version;

	hid->country = req->country;



	strncpy(hid->name, req->name, 128);

	strncpy(hid->name, req->name, sizeof(req->name) - 1);



	snprintf(hid->phys, sizeof(hid->phys), "%pMR",

		 &bt_sk(session->ctrl_sock->sk)->src);