Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a990614 authored by Roel Kluin's avatar Roel Kluin Committed by Mike Frysinger
Browse files

Blackfin: fix length checking in kgdb_ebin2mem 



The kgdb_ebin2mem() was decrementing the count variable to do parsing, but
then later still tries to use it based on its original meaning.  So leave
it untouched and use a different variable to walk the memory.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
parent 11aca0e7

arch/blackfin/kernel/kgdb.c

+2 −3
Original line number Diff line number Diff line
@@ -587,19 +587,18 @@ int kgdb_ebin2mem(char *buf, char *mem, int count) 
	unsigned short *mmr16;

	unsigned long *mmr32;

	int err;

	int size = 0;

	int size;

	int cpu = raw_smp_processor_id();



	tmp_old = tmp_new = buf;



	while (count-- > 0) {

	for (size = 0; size < count; ++size) {

		if (*tmp_old == 0x7d)

			*tmp_new = *(++tmp_old) ^ 0x20;

		else

			*tmp_new = *tmp_old;

		tmp_new++;

		tmp_old++;

		size++;

	}



	err = validate_memory_access_address((unsigned long)mem, size);