Commit 0a95b851 authored Jan 22, 2016 by Qu Wenruo Committed by Chris Mason Jan 25, 2016

btrfs: async-thread: Fix a use-after-free error for trace



Parameter of trace_btrfs_work_queued() can be freed in its workqueue.
So no one use use that pointer after queue_work().

Fix the user-after-free bug by move the trace line before queue_work().

Reported-by: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>

parent de0ee0ed

fs/btrfs/async-thread.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -328,8 +328,8 @@ static inline void __btrfs_queue_work(struct __btrfs_workqueue *wq,
		list_add_tail(&work->ordered_list, &wq->ordered_list);
		spin_unlock_irqrestore(&wq->list_lock, flags);
		}
		queue_work(wq->normal_wq, &work->normal_work);
		trace_btrfs_work_queued(work);
		queue_work(wq->normal_wq, &work->normal_work);
		}

		void btrfs_queue_work(struct btrfs_workqueue *wq,