Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a6b2923 authored by Dan Carpenter's avatar Dan Carpenter Committed by John Johansen
Browse files

apparmor: fix an error code in __aa_create_ns() 



We should return error pointers in this function.  Returning NULL
results in a NULL dereference in the caller.

Fixes: 73688d1e ("apparmor: refactor prepare_ns() and make usable from different views")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJohn Johansen <john.johansen@canonical.com>
parent 24b87a16

security/apparmor/policy_ns.c

+1 −1
Original line number Diff line number Diff line
@@ -255,7 +255,7 @@ static struct aa_ns *__aa_create_ns(struct aa_ns *parent, const char *name, 


	ns = alloc_ns(parent->base.hname, name);

	if (!ns)

		return NULL;

		return ERR_PTR(-ENOMEM);

	ns->level = parent->level + 1;

	mutex_lock_nested(&ns->lock, ns->level);

	error = __aafs_ns_mkdir(ns, ns_subns_dir(parent), name, dir);