Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a3dabb1 authored by Devin Heitmueller's avatar Devin Heitmueller Committed by Mauro Carvalho Chehab
Browse files

[media] xc5000: properly report i2c write failures 



The logic as written would *never* actually return an error condition,
since the loop would run until the counter hit zero but the check was
for a value less than zero.

Signed-off-by: default avatarDevin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 7c287f18

drivers/media/common/tuners/xc5000.c

+1 −1
Original line number Diff line number Diff line
@@ -343,7 +343,7 @@ static int xc_write_reg(struct xc5000_priv *priv, u16 regAddr, u16 i2cData) 
			}

		}

	}

	if (WatchDogTimer < 0)

	if (WatchDogTimer <= 0)

		result = XC_RESULT_I2C_WRITE_FAILURE;



	return result;