Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a370d26 authored by Dan Williams's avatar Dan Williams Committed by Ross Zwisler
Browse files

libnvdimm, pmem: clarify the write+clear_poison+write flow 



The ACPI specification does not specify the state of data after a clear
poison operation.  Potential future libnvdimm bus implementations for
other architectures also might not specify or disagree on the state of
data after clear poison.  Clarify why we write twice.

Reported-by: default avatarJeff Moyer <jmoyer@redhat.com>
Reported-by: default avatarVishal Verma <vishal.l.verma@intel.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarRoss Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: default avatarJeff Moyer <jmoyer@redhat.com>
Reviewed-by: default avatarVishal Verma <vishal.l.verma@intel.com>
parent cba2e47a

drivers/nvdimm/pmem.c

+14 −0
Original line number Diff line number Diff line
@@ -103,6 +103,20 @@ static int pmem_do_bvec(struct pmem_device *pmem, struct page *page, 
			flush_dcache_page(page);

		}

	} else {

		/*

		 * Note that we write the data both before and after

		 * clearing poison.  The write before clear poison

		 * handles situations where the latest written data is

		 * preserved and the clear poison operation simply marks

		 * the address range as valid without changing the data.

		 * In this case application software can assume that an

		 * interrupted write will either return the new good

		 * data or an error.

		 *

		 * However, if pmem_clear_poison() leaves the data in an

		 * indeterminate state we need to perform the write

		 * after clear poison.

		 */

		flush_dcache_page(page);

		memcpy_to_pmem(pmem_addr, mem + off, len);

		if (unlikely(bad_pmem)) {