Commit 0976a03e authored Jun 22, 2011 by Oleg Nesterov

reparent_leader: check EXIT_DEAD instead of task_detached()



Change reparent_leader() to check ->exit_state instead of ->exit_signal,
this matches the similar EXIT_DEAD check in wait_consider_task() and
allows us to cleanup the do_notify_parent/task_detached logic.

task_detached() was really needed during reparenting before 9cd80bbb
"do_wait() optimization: do not place sub-threads on ->children list"
to filter out the sub-threads. After this change task_detached(p) can
only be true if p is the dead group_leader and its parent ignores
SIGCHLD, in this case the caller of do_notify_parent() is going to
reap this task and it should set EXIT_DEAD.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Tejun Heo <tj@kernel.org>

parent 86773473

kernel/exit.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -742,7 +742,7 @@ static void reparent_leader(struct task_struct father, struct task_struct p,
		{
		list_move_tail(&p->sibling, &p->real_parent->children);

		if (task_detached(p))
		if (p->exit_state == EXIT_DEAD)
		return;
		/*
		* If this is a threaded reparent there is no need to