Commit 0968cf51 authored Oct 10, 2006 by Jeff Garzik Committed by Linus Torvalds Oct 10, 2006

[PATCH] firmware/dcdbas: fix bug in error cleanup



The error path path mistakenly called sysfs_create_group() rather than
sysfs_remove_group().  They take the same arguments, so it's easy to
cut-n-paste such a bug.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 15e541fe

drivers/firmware/dcdbas.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -559,7 +559,7 @@ static int __devinit dcdbas_probe(struct platform_device *dev)
		while (--i >= 0)
		sysfs_remove_bin_file(&dev->dev.kobj,
		dcdbas_bin_attrs[i]);
		sysfs_create_group(&dev->dev.kobj, &dcdbas_attr_group);
		sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group);
		return error;
		}
		}