Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09624645 authored by Raghava Aditya Renukunta's avatar Raghava Aditya Renukunta Committed by Martin K. Petersen
Browse files

scsi: aacraid: Save adapter fib log before an IOP reset 



Currently  the adapter firmware does not save outstanding I/O's log
information  when an IOP reset is triggered. This is problematic when
trying to root cause and debug issues.

Fixed by adding sync command to trigger I/O log file save in the adapter
firmware before issuing an IOP reset.

Signed-off-by: default avatarRaghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Reviewed-by: default avatarDavid Carroll <David.Carroll@microsemi.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c421530b

drivers/scsi/aacraid/aachba.c

+4 −0
Original line number Diff line number Diff line
@@ -294,6 +294,10 @@ MODULE_PARM_DESC(aif_timeout, "The duration of time in seconds to wait for" 
	"deregistering them. This is typically adjusted for heavily burdened"

	" systems.");



int aac_fib_dump;

module_param(aac_fib_dump, int, 0644);

MODULE_PARM_DESC(aac_fib_dump, "Dump controller fibs prior to IOP_RESET 0=off, 1=on");



int numacb = -1;

module_param(numacb, int, S_IRUGO|S_IWUSR);

MODULE_PARM_DESC(numacb, "Request a limit to the number of adapter control"

drivers/scsi/aacraid/aacraid.h

+6 −0
Original line number Diff line number Diff line
@@ -1444,6 +1444,10 @@ struct aac_supplement_adapter_info 
#define AAC_OPTION_VARIABLE_BLOCK_SIZE	cpu_to_le32(0x00040000)

/* 240 simple volume support */

#define AAC_OPTION_SUPPORTED_240_VOLUMES cpu_to_le32(0x10000000)

/*

 * Supports FIB dump sync command send prior to IOP_RESET

 */

#define AAC_OPTION_SUPPORTED3_IOP_RESET_FIB_DUMP	cpu_to_le32(0x00004000)

#define AAC_SIS_VERSION_V3	3

#define AAC_SIS_SLOT_UNKNOWN	0xFF
@@ -2483,6 +2487,7 @@ struct aac_hba_info { 
#define GET_DRIVER_BUFFER_PROPERTIES	0x00000023

#define RCV_TEMP_READINGS		0x00000025

#define GET_COMM_PREFERRED_SETTINGS	0x00000026

#define IOP_RESET_FW_FIB_DUMP		0x00000034

#define IOP_RESET			0x00001000

#define IOP_RESET_ALWAYS		0x00001001

#define RE_INIT_ADAPTER			0x000000ee
@@ -2686,4 +2691,5 @@ extern int aac_commit; 
extern int update_interval;

extern int check_interval;

extern int aac_check_reset;

extern int aac_fib_dump;

#endif

drivers/scsi/aacraid/src.c

+17 −0
Original line number Diff line number Diff line
@@ -679,10 +679,27 @@ void aac_set_intx_mode(struct aac_dev *dev) 
	}

}



static void aac_dump_fw_fib_iop_reset(struct aac_dev *dev)

{

	__le32 supported_options3;



	if (!aac_fib_dump)

		return;



	supported_options3  = dev->supplement_adapter_info.supported_options3;

	if (!(supported_options3 & AAC_OPTION_SUPPORTED3_IOP_RESET_FIB_DUMP))

		return;



	aac_adapter_sync_cmd(dev, IOP_RESET_FW_FIB_DUMP,

			0, 0, 0,  0, 0, 0, NULL, NULL, NULL, NULL, NULL);

}



static void aac_send_iop_reset(struct aac_dev *dev, int bled)

{

	u32 var, reset_mask;



	aac_dump_fw_fib_iop_reset(dev);



	bled = aac_adapter_sync_cmd(dev, IOP_RESET_ALWAYS,

				    0, 0, 0, 0, 0, 0, &var,

				    &reset_mask, NULL, NULL, NULL);