Commit 090b7402 authored Apr 12, 2019 by Colin Ian King Committed by Greg Kroah-Hartman May 16, 2019

vxge: fix return of a free'd memblock on a failed dma mapping



[ Upstream commit 0a2c34f18c94b596562bf3d019fceab998b8b584 ]

Currently if a pci dma mapping failure is detected a free'd
memblock address is returned rather than a NULL (that indicates
an error). Fix this by ensuring NULL is returned on this error case.

Addresses-Coverity: ("Use after free")
Fixes: 528f7272 ("vxge: code cleanup and reorganization")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f83beff2

drivers/net/ethernet/neterion/vxge/vxge-config.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2365,6 +2365,7 @@ static void __vxge_hw_blockpool_malloc(struct __vxge_hw_device devh, u32 size,
		dma_object->addr))) {
		vxge_os_dma_free(devh->pdev, memblock,
		&dma_object->acc_handle);
		memblock = NULL;
		goto exit;
		}