Commit 086eec2d authored Apr 04, 2016 by Dan Carpenter Committed by Marc Zyngier May 11, 2016

irqchip/mbigen: Checking for IS_ERR() instead of NULL



of_platform_device_create() returns NULL on error, it never returns
error pointers.

Fixes: ed2a1002 ('irqchip/mbigen: Handle multiple device nodes in a mbigen module')
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

parent 074f23b6

drivers/irqchip/irq-mbigen.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -263,8 +263,8 @@ static int mbigen_device_probe(struct platform_device *pdev)

		parent = platform_bus_type.dev_root;
		child = of_platform_device_create(np, NULL, parent);
		if (IS_ERR(child))
		return PTR_ERR(child);
		if (!child)
		return -ENOMEM;

		if (of_property_read_u32(child->dev.of_node, "num-pins",
		&num_pins) < 0) {