Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0854f665 authored by Lalit Chandivade's avatar Lalit Chandivade Committed by James Bottomley
Browse files

[SCSI] qla4xxx: Fix bidirectional CHAP. 



Driver was not setting the bidirectional CHAP bit correctly in
the DDB entry.

JIRA Key: UPSISCSI-108

Signed-off-by: default avatarLalit Chandivade <lalit.chandivade@qlogic.com>
Signed-off-by: default avatarVikas Chaudhary <vikas.chaudhary@qlogic.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent aecc3130

drivers/scsi/qla4xxx/ql4_def.h

+2 −0
Original line number Diff line number Diff line
@@ -351,6 +351,8 @@ struct ipaddress_config { 


#define QL4_CHAP_MAX_NAME_LEN 256

#define QL4_CHAP_MAX_SECRET_LEN 100

#define LOCAL_CHAP	0

#define BIDI_CHAP	1



struct ql4_chap_format {

	u8  intr_chap_name[QL4_CHAP_MAX_NAME_LEN];

drivers/scsi/qla4xxx/ql4_mbx.c

+4 −3
Original line number Diff line number Diff line
@@ -872,7 +872,6 @@ void qla4xxx_get_conn_event_log(struct scsi_qla_host * ha) 
	uint32_t	max_event_log_entries;

	uint8_t		i;





	memset(&mbox_cmd, 0, sizeof(mbox_cmd));

	memset(&mbox_sts, 0, sizeof(mbox_cmd));
@@ -1578,7 +1577,8 @@ int qla4xxx_set_param_ddbentry(struct scsi_qla_host *ha, 
			}



			rval = qla4xxx_set_chap(ha, sess->username,

						sess->password, idx, 0);

						sess->password, idx,

						LOCAL_CHAP);

			if (rval)

				goto exit_set_param;
@@ -1599,7 +1599,8 @@ int qla4xxx_set_param_ddbentry(struct scsi_qla_host *ha, 
				goto exit_set_param;

			}

			rval = qla4xxx_set_chap(ha, sess->username_in,

						sess->password_in, idx, 0);

						sess->password_in, idx,

						BIDI_CHAP);

			if (rval)

				goto exit_set_param;

		}