Commit 0851561d authored Apr 12, 2016 by Xiaodong Liu Committed by Herbert Xu Apr 15, 2016

crypto: sha1-mb - use corrcet pointer while completing jobs



In sha_complete_job, incorrect mcryptd_hash_request_ctx pointer is used
when check and complete other jobs. If the memory of first completed req
is freed, while still completing other jobs in the func, kernel will
crash since NULL pointer is assigned to RIP.

Cc: <stable@vger.kernel.org>
Signed-off-by: Xiaodong Liu <xiaodong.liu@intel.com>
Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 6f0904ad

arch/x86/crypto/sha-mb/sha1_mb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -453,10 +453,10 @@ static int sha_complete_job(struct mcryptd_hash_request_ctx *rctx,

		req = cast_mcryptd_ctx_to_req(req_ctx);
		if (irqs_disabled())
		rctx->complete(&req->base, ret);
		req_ctx->complete(&req->base, ret);
		else {
		local_bh_disable();
		rctx->complete(&req->base, ret);
		req_ctx->complete(&req->base, ret);
		local_bh_enable();
		}
		}