Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 082e708a authored by Roel Kluin's avatar Roel Kluin Committed by John W. Linville
Browse files

iwlwifi: Read outside array bounds 



tid is bounded (above) by the size of default_tid_to_tx_fifo (17 elements), but
the size of priv->stations[].tid[] is MAX_TID_COUNT (9) elements.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 008749fc

drivers/net/wireless/iwlwifi/iwl-tx.c

+2 −0
Original line number Diff line number Diff line
@@ -1171,6 +1171,8 @@ int iwl_tx_agg_start(struct iwl_priv *priv, const u8 *ra, u16 tid, u16 *ssn) 
		IWL_ERR(priv, "Start AGG on invalid station\n");

		return -ENXIO;

	}

	if (unlikely(tid >= MAX_TID_COUNT))

		return -EINVAL;



	if (priv->stations[sta_id].tid[tid].agg.state != IWL_AGG_OFF) {

		IWL_ERR(priv, "Start AGG when state is not IWL_AGG_OFF !\n");