Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 080ba929 authored by Mike Frysinger's avatar Mike Frysinger Committed by Linus Torvalds
Browse files

checkpatch: try to catch missing VMLINUX_SYMBOL() in vmlinux.lds.h 



Seems like every other release we have someone who updates vmlinux.lds.h
and adds C-visible symbols without VMLINUX_SYMBOL() around them.  So start
checking the file and reject assignments which have plain symbols on
either side.

[apw@canonical.com: soften the check, add tests]
Signed-off-by: default avatarMike Frysinger <vapier@gentoo.org>
Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 86f9d059

scripts/checkpatch.pl

+9 −0
Original line number Original line Diff line number Diff line
@@ -2224,6 +2224,15 @@ sub process { 
			}

			}

		}

		}





# make sure symbols are always wrapped with VMLINUX_SYMBOL() ...

# all assignments may have only one of the following with an assignment:

#	.

#	ALIGN(...)

#	VMLINUX_SYMBOL(...)

		if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {

			WARN("vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);

		}



# check for redundant bracing round if etc

# check for redundant bracing round if etc

		if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {

		if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {

			my ($level, $endln, @chunks) =

			my ($level, $endln, @chunks) =