Commit 07d86ca9 authored Feb 13, 2016 by Andrey Konovalov Committed by Takashi Iwai Feb 13, 2016

ALSA: usb-audio: avoid freeing umidi object twice



The 'umidi' object will be free'd on the error path by snd_usbmidi_free()
when tearing down the rawmidi interface. So we shouldn't try to free it
in snd_usbmidi_create() after having registered the rawmidi interface.

Found by KASAN.

Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 86c2ee16

sound/usb/midi.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2455,7 +2455,6 @@ int snd_usbmidi_create(struct snd_card *card,
		else
		err = snd_usbmidi_create_endpoints(umidi, endpoints);
		if (err < 0) {
		snd_usbmidi_free(umidi);
		return err;
		}