Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06c5ec6f authored by Ruslan Babayev's avatar Ruslan Babayev Committed by Greg Kroah-Hartman
Browse files

iio: dac: ds4422/ds4424 fix chip verification 



commit 60f2208699ec08ff9fdf1f97639a661a92a18f1c upstream.

The ds4424_get_value function takes channel number as it's 3rd
argument and translates it internally into I2C address using
DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an
already translated I2C address as its last argument.

Signed-off-by: default avatarRuslan Babayev <ruslan@babayev.com>
Cc: xe-linux-external@cisco.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8a652fd1

drivers/iio/dac/ds4424.c

+1 −1
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio_dev *indio_dev) 
{

	int ret, val;



	ret = ds4424_get_value(indio_dev, &val, DS4424_DAC_ADDR(0));

	ret = ds4424_get_value(indio_dev, &val, 0);

	if (ret < 0)

		dev_err(&indio_dev->dev,

				"%s failed. ret: %d\n", __func__, ret);