Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06a70305 authored by Darrick J. Wong's avatar Darrick J. Wong
Browse files

ocfs2: prohibit refcounted swapfiles 



The swapfile mechanism calls bmap once to find all the swap file
mappings, which means that we cannot properly support CoW remapping.
Therefore, error out if the swap code tries to call bmap on a
refcounted file.

Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent 86544fbd

fs/ocfs2/aops.c

+9 −0
Original line number Original line Diff line number Diff line
@@ -464,6 +464,15 @@ static sector_t ocfs2_bmap(struct address_space *mapping, sector_t block) 
	trace_ocfs2_bmap((unsigned long long)OCFS2_I(inode)->ip_blkno,

	trace_ocfs2_bmap((unsigned long long)OCFS2_I(inode)->ip_blkno,

			 (unsigned long long)block);

			 (unsigned long long)block);





	/*

	 * The swap code (ab-)uses ->bmap to get a block mapping and then

	 * bypasseѕ the file system for actual I/O.  We really can't allow

	 * that on refcounted inodes, so we have to skip out here.  And yes,

	 * 0 is the magic code for a bmap error..

	 */

	if (ocfs2_is_refcount_inode(inode))

		return 0;



	/* We don't need to lock journal system files, since they aren't

	/* We don't need to lock journal system files, since they aren't

	 * accessed concurrently from multiple nodes.

	 * accessed concurrently from multiple nodes.

	 */

	 */