Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06a221be authored by Ming Lei's avatar Ming Lei Committed by David S. Miller
Browse files

usbnet: smsc95xx: fix memory leak in smsc95xx_suspend 



This patch fixes memory leak in smsc95xx_suspend.

Also, it isn't necessary to bother mm to allocate 8bytes/16byte,
and we can use stack variable safely.

Acked-By: default avatarSteve Glendinning <steve.glendinning@shawell.net>
Signed-off-by: default avatarMing Lei <ming.lei@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 47bbea41

drivers/net/usb/smsc95xx.c

+10 −3
Original line number Diff line number Diff line
@@ -1070,11 +1070,15 @@ static int smsc95xx_suspend(struct usb_interface *intf, pm_message_t message) 


	if (pdata->wolopts & (WAKE_BCAST | WAKE_MCAST | WAKE_ARP | WAKE_UCAST)) {

		u32 *filter_mask = kzalloc(32, GFP_KERNEL);

		u32 *command = kzalloc(2, GFP_KERNEL);

		u32 *offset = kzalloc(2, GFP_KERNEL);

		u32 *crc = kzalloc(4, GFP_KERNEL);

		u32 command[2];

		u32 offset[2];

		u32 crc[4];

		int i, filter = 0;



		memset(command, 0, sizeof(command));

		memset(offset, 0, sizeof(offset));

		memset(crc, 0, sizeof(crc));



		if (pdata->wolopts & WAKE_BCAST) {

			const u8 bcast[] = {0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF};

			netdev_info(dev->net, "enabling broadcast detection");
@@ -1128,8 +1132,11 @@ static int smsc95xx_suspend(struct usb_interface *intf, pm_message_t message) 


		for (i = 0; i < (pdata->wuff_filter_count * 4); i++) {

			ret = smsc95xx_write_reg(dev, WUFF, filter_mask[i]);

			if (ret < 0)

				kfree(filter_mask);

			check_warn_return(ret, "Error writing WUFF");

		}

		kfree(filter_mask);



		for (i = 0; i < (pdata->wuff_filter_count / 4); i++) {

			ret = smsc95xx_write_reg(dev, WUFF, command[i]);