Commit 0686e402 authored Aug 21, 2008 by Jan Glauber Committed by Martin Schwidefsky Aug 21, 2008

[S390] qdio: remove the module_get & module_put pair



Increasing the qdio reference count for every used subchannel
is unnecessary since unloading qdio (if build as a module) is
only possible if other modules that use qdio are unloaded.
Unloading modules that use qdio in turn requires that these
modules shut down all qdio subchannels. Therefore the additional
module_get reference is not needed.

Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

parent 58eb27cd

drivers/s390/cio/qdio_main.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1251,7 +1251,6 @@ int qdio_shutdown(struct ccw_device *cdev, int how)

		qdio_set_state(irq_ptr, QDIO_IRQ_STATE_INACTIVE);
		mutex_unlock(&irq_ptr->setup_mutex);
		module_put(THIS_MODULE);
		if (rc)
		return rc;
		return 0;
		@@ -1399,9 +1398,6 @@ int qdio_establish(struct qdio_initialize *init_data)
		if (cdev->private->state != DEV_STATE_ONLINE)
		return -EINVAL;

		if (!try_module_get(THIS_MODULE))
		return -EINVAL;

		mutex_lock(&irq_ptr->setup_mutex);
		qdio_setup_irq(init_data);