Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 062d6c2a authored by Masami Hiramatsu's avatar Masami Hiramatsu Committed by Arnaldo Carvalho de Melo
Browse files

perf probe: Close target file on error path 



Fix a bug to close target elf file in get_text_start_address().

Signed-off-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20160426064737.1443.44093.stgit@devbox


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent b04b7023

tools/perf/util/probe-event.c

+7 −2
Original line number Diff line number Diff line
@@ -486,8 +486,10 @@ static int get_text_start_address(const char *exec, unsigned long *address) 
		return -errno;



	elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL);

	if (elf == NULL)

		return -EINVAL;

	if (elf == NULL) {

		ret = -EINVAL;

		goto out_close;

	}



	if (gelf_getehdr(elf, &ehdr) == NULL)

		goto out;
@@ -499,6 +501,9 @@ static int get_text_start_address(const char *exec, unsigned long *address) 
	ret = 0;

out:

	elf_end(elf);

out_close:

	close(fd);



	return ret;

}