Commit 053b783d authored Nov 09, 2018 by Colin Ian King Committed by Greg Kroah-Hartman Dec 05, 2018

staging: most: use format specifier "%s" in snprintf



commit 13c45007e0a87e912da21223599583fdea677914 upstream.

Passing string ch_data_type[i].name as the format specifier is
potentially hazardous because it could (although very unlikely to)
have a format specifier embedded in it causing issues when parsing
the non-existent arguments to these.  Follow best practice by using
the "%s" format string for the string.

Cleans up clang warning:
format string is not a string literal (potentially insecure) [-Wformat-security]

Fixes: e7f2b70f ("staging: most: replace multiple if..else with table lookup")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0d04d450

drivers/staging/most/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -351,7 +351,7 @@ static ssize_t set_datatype_show(struct device *dev,

		for (i = 0; i < ARRAY_SIZE(ch_data_type); i++) {
		if (c->cfg.data_type & ch_data_type[i].most_ch_data_type)
		return snprintf(buf, PAGE_SIZE, ch_data_type[i].name);
		return snprintf(buf, PAGE_SIZE, "%s", ch_data_type[i].name);
		}
		return snprintf(buf, PAGE_SIZE, "unconfigured\n");
		}