Commit 04db70d9 authored Aug 08, 2017 by Girish Moodalbail Committed by David S. Miller Aug 09, 2017

geneve: maximum value of VNI cannot be used



Geneve's Virtual Network Identifier (VNI) is 24 bit long, so the range
of values for it would be from 0 to 16777215 (2^24 -1).  However, one
cannot create a geneve device with VNI set to 16777215. This patch fixes
this issue.

Signed-off-by: Girish Moodalbail <girish.moodalbail@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 50ddfbaf

drivers/net/geneve.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1091,7 +1091,7 @@ static int geneve_validate(struct nlattr tb[], struct nlattr data[],
		if (data[IFLA_GENEVE_ID]) {
		__u32 vni = nla_get_u32(data[IFLA_GENEVE_ID]);

		if (vni >= GENEVE_VID_MASK)
		if (vni >= GENEVE_N_VID)
		return -ERANGE;
		}