Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 047d72c3 authored by Johannes Weiner's avatar Johannes Weiner Committed by Linus Torvalds
Browse files

mm: remove seemingly spurious reclaimability check from laptop_mode gating 

Commit 1d82de61 ("mm, vmscan: make kswapd reclaim in terms of
nodes") allowed laptop_mode=1 to start writing not just when the
priority drops to DEF_PRIORITY - 2 but also when the node is
unreclaimable.

That appears to be a spurious change in this patch as I doubt the series
was tested with laptop_mode, and neither is that particular change
mentioned in the changelog.  Remove it, it's still recent.

Link: http://lkml.kernel.org/r/20170228214007.5621-4-hannes@cmpxchg.org


Signed-off-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Acked-by: default avatarHillf Danton <hillf.zj@alibaba-inc.com>
Acked-by: default avatarMel Gorman <mgorman@techsingularity.net>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Cc: Jia He <hejianet@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d450abd8

mm/vmscan.c

+1 −1
Original line number Diff line number Diff line
@@ -3285,7 +3285,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx) 
		 * If we're getting trouble reclaiming, start doing writepage

		 * even in laptop mode.

		 */

		if (sc.priority < DEF_PRIORITY - 2 || !pgdat_reclaimable(pgdat))

		if (sc.priority < DEF_PRIORITY - 2)

			sc.may_writepage = 1;



		/* Call soft limit reclaim before calling shrink_node. */