Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04719507 authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

mlxsw: spectrum_acl: Do not invalidate already invalid ACL groups 



When a new ACL group is created its region (ACL) list is initially
empty. Thus, the call to mlxsw_sp_acl_tcam_group_update() would
basically invalidate an already invalid (non-existent) group.

Remove the unnecessary call and make the function symmetric to its del()
counterpart.

Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 808be37a

drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c

+0 −5
Original line number Diff line number Diff line
@@ -228,10 +228,6 @@ mlxsw_sp_acl_tcam_group_add(struct mlxsw_sp *mlxsw_sp, 
	if (err)

		return err;



	err = mlxsw_sp_acl_tcam_group_update(mlxsw_sp, group);

	if (err)

		goto err_group_update;



	err = rhashtable_init(&group->chunk_ht,

			      &mlxsw_sp_acl_tcam_chunk_ht_params);

	if (err)
@@ -240,7 +236,6 @@ mlxsw_sp_acl_tcam_group_add(struct mlxsw_sp *mlxsw_sp, 
	return 0;



err_rhashtable_init:

err_group_update:

	mlxsw_sp_acl_tcam_group_id_put(tcam, group->id);

	return err;

}