Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0461f34e authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki
Browse files

Utilities: Fix missing parentheses in ACPI_GET_BITS()/ACPI_SET_BITS() 

Some compilers require parentheses to be enforced in the macro definition,
so that the macro caller side can be simpler.

This patch fixes this kind of macro issue in
ACPI_SET_BITS()/ACPI_GET_BITS(). Lv Zheng.

Link: https://bugs.acpica.org/show_bug.cgi?id=1268


Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent a8d1e1c0

drivers/acpi/acpica/acmacros.h

+2 −2
Original line number Original line Diff line number Diff line
@@ -287,10 +287,10 @@ 
/* Generic bitfield macros and masks */

/* Generic bitfield macros and masks */





#define ACPI_GET_BITS(source_ptr, position, mask) \

#define ACPI_GET_BITS(source_ptr, position, mask) \

	((*source_ptr >> position) & mask)

	((*(source_ptr) >> (position)) & (mask))





#define ACPI_SET_BITS(target_ptr, position, mask, value) \

#define ACPI_SET_BITS(target_ptr, position, mask, value) \

	(*target_ptr |= ((value & mask) << position))

	(*(target_ptr) |= (((value) & (mask)) << (position)))





#define ACPI_1BIT_MASK      0x00000001

#define ACPI_1BIT_MASK      0x00000001

#define ACPI_2BIT_MASK      0x00000003

#define ACPI_2BIT_MASK      0x00000003